From 7360c1f832bb4f8b610d35b262fb37e49cdb0231 Mon Sep 17 00:00:00 2001 From: Sylvain Berfini Date: Mon, 4 Mar 2019 21:20:02 +0100 Subject: [PATCH] Improved dark theme --- .../contacts/ContactEditorFragment.java | 10 ++---- .../settings/LinphonePreferences.java | 11 ++++--- .../res/drawable/button_background_dark.xml | 11 +++++++ ...ground.xml => button_background_light.xml} | 3 +- app/src/main/res/drawable/toolbar_button.xml | 9 ------ app/src/main/res/layout-land/about.xml | 4 +-- app/src/main/res/layout-land/call.xml | 24 +++++++------- app/src/main/res/layout-land/dialer.xml | 2 +- app/src/main/res/layout-land/main.xml | 5 +-- .../main/res/layout-sw533dp-land/dialer.xml | 2 +- app/src/main/res/layout-sw533dp-land/main.xml | 5 +-- app/src/main/res/layout-sw533dp/dialer.xml | 2 +- app/src/main/res/layout-sw533dp/main.xml | 5 +-- app/src/main/res/layout/about.xml | 10 +++--- app/src/main/res/layout/assistant_topbar.xml | 7 ++-- app/src/main/res/layout/call.xml | 24 +++++++------- app/src/main/res/layout/call_outgoing.xml | 4 +-- app/src/main/res/layout/chat.xml | 20 +++++++----- app/src/main/res/layout/chat_create.xml | 18 ++++++----- app/src/main/res/layout/chat_device_group.xml | 3 +- app/src/main/res/layout/chat_devices.xml | 14 +++----- app/src/main/res/layout/chat_imdn.xml | 2 +- app/src/main/res/layout/chat_imdn_old.xml | 2 +- app/src/main/res/layout/chat_infos.xml | 14 ++++---- app/src/main/res/layout/chatlist.xml | 18 +++++++---- app/src/main/res/layout/contact.xml | 12 ++++--- app/src/main/res/layout/contact_edit.xml | 31 +++++------------- app/src/main/res/layout/contacts_list.xml | 11 +++---- app/src/main/res/layout/dialer.xml | 2 +- app/src/main/res/layout/edit_list.xml | 15 +++++---- app/src/main/res/layout/history.xml | 6 ++-- app/src/main/res/layout/history_detail.xml | 10 +++--- app/src/main/res/layout/in_app.xml | 4 +-- app/src/main/res/layout/main.xml | 5 +-- app/src/main/res/layout/recordings_list.xml | 7 ++-- .../res/layout/side_menu_account_cell.xml | 6 ++-- .../main/res/layout/side_menu_item_cell.xml | 1 - .../res/layout/side_menu_main_account.xml | 17 ++++------ app/src/main/res/values/attrs.xml | 1 + app/src/main/res/values/styles.xml | 32 ++++++++++++++----- 40 files changed, 206 insertions(+), 183 deletions(-) create mode 100644 app/src/main/res/drawable/button_background_dark.xml rename app/src/main/res/drawable/{button_background.xml => button_background_light.xml} (80%) delete mode 100644 app/src/main/res/drawable/toolbar_button.xml diff --git a/app/src/main/java/org/linphone/contacts/ContactEditorFragment.java b/app/src/main/java/org/linphone/contacts/ContactEditorFragment.java index e64968494..df3c4fc04 100644 --- a/app/src/main/java/org/linphone/contacts/ContactEditorFragment.java +++ b/app/src/main/java/org/linphone/contacts/ContactEditorFragment.java @@ -58,8 +58,8 @@ import org.linphone.R; import org.linphone.core.tools.Log; import org.linphone.mediastream.Version; import org.linphone.utils.FileUtils; -import org.linphone.utils.ImageUtils; import org.linphone.utils.LinphoneUtils; +import org.linphone.views.ContactAvatar; public class ContactEditorFragment extends Fragment { private static final int ADD_PHOTO = 1337; @@ -311,13 +311,9 @@ public class ContactEditorFragment extends Fragment { mContactPicture = mView.findViewById(R.id.contact_picture); if (mContact != null) { - ImageUtils.setImagePictureFromUri( - getActivity(), - mContactPicture, - mContact.getPhotoUri(), - mContact.getThumbnailUri()); + ContactAvatar.displayAvatar(mContact, mView.findViewById(R.id.avatar_layout)); } else { - ImageUtils.setDefaultContactImage(mContactPicture); + ContactAvatar.displayAvatar("", mView.findViewById(R.id.avatar_layout)); } mContactPicture.setOnClickListener( diff --git a/app/src/main/java/org/linphone/settings/LinphonePreferences.java b/app/src/main/java/org/linphone/settings/LinphonePreferences.java index f4b84230d..e5a006fb0 100644 --- a/app/src/main/java/org/linphone/settings/LinphonePreferences.java +++ b/app/src/main/java/org/linphone/settings/LinphonePreferences.java @@ -22,6 +22,7 @@ Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA. import android.Manifest; import android.content.Context; import android.content.pm.PackageManager; +import androidx.appcompat.app.AppCompatDelegate; import java.io.BufferedReader; import java.io.File; import java.io.IOException; @@ -1432,13 +1433,15 @@ public class LinphonePreferences { } public boolean isDarkModeEnabled() { - return /*AppCompatDelegate.getDefaultNightMode() == AppCompatDelegate.MODE_NIGHT_YES - && */ getConfig().getBool("app", "dark_mode", false); + return getConfig() + .getBool( + "app", + "dark_mode", + AppCompatDelegate.getDefaultNightMode() + == AppCompatDelegate.MODE_NIGHT_YES); } public void enableDarkMode(boolean enable) { - /*AppCompatDelegate.setDefaultNightMode( - enable ? AppCompatDelegate.MODE_NIGHT_YES : AppCompatDelegate.MODE_NIGHT_NO);*/ getConfig().setBool("app", "dark_mode", enable); } diff --git a/app/src/main/res/drawable/button_background_dark.xml b/app/src/main/res/drawable/button_background_dark.xml new file mode 100644 index 000000000..8f3843085 --- /dev/null +++ b/app/src/main/res/drawable/button_background_dark.xml @@ -0,0 +1,11 @@ + + + + + + + diff --git a/app/src/main/res/drawable/button_background.xml b/app/src/main/res/drawable/button_background_light.xml similarity index 80% rename from app/src/main/res/drawable/button_background.xml rename to app/src/main/res/drawable/button_background_light.xml index c33946ec4..bc101d5e2 100644 --- a/app/src/main/res/drawable/button_background.xml +++ b/app/src/main/res/drawable/button_background_light.xml @@ -4,7 +4,8 @@ android:drawable="@color/colorE" /> + - diff --git a/app/src/main/res/drawable/toolbar_button.xml b/app/src/main/res/drawable/toolbar_button.xml deleted file mode 100644 index 3fa8135d8..000000000 --- a/app/src/main/res/drawable/toolbar_button.xml +++ /dev/null @@ -1,9 +0,0 @@ - - - - - - \ No newline at end of file diff --git a/app/src/main/res/layout-land/about.xml b/app/src/main/res/layout-land/about.xml index f7f0fb2ab..326212248 100644 --- a/app/src/main/res/layout-land/about.xml +++ b/app/src/main/res/layout-land/about.xml @@ -119,7 +119,7 @@ android:layout_width="match_parent" android:layout_height="wrap_content" android:layout_margin="5dp" - android:background="@drawable/button_background" + android:background="?attr/button_background_drawable" android:text="@string/menu_send_log" />