Difuse/difuse-phone-android
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

Improvements suggested by code inspector

Browse source
This commit is contained in:
Sylvain Berfini 2022-04-08 17:47:11 +02:00
parent a04c09b748
commit 5fd69bcd4c
17 changed files with 84 additions and 79 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
app/build.gradle
View file

@ -204,7 +204,7 @@ android {
dependencies { dependencies {
implementation fileTree(dir: 'libs', include: ['*.jar']) implementation fileTree(dir: 'libs', include: ['*.jar'])
implementation 'androidx.appcompat:appcompat:1.4.1' implementation 'androidx.appcompat:appcompat:1.4.1'
implementation 'androidx.media:media:1.4.3' implementation 'androidx.media:media:1.5.0'
implementation 'androidx.fragment:fragment-ktx:1.4.1' implementation 'androidx.fragment:fragment-ktx:1.4.1'
implementation 'androidx.core:core-ktx:1.7.0' implementation 'androidx.core:core-ktx:1.7.0'

2
app/src/main/java/org/linphone/activities/main/chat/adapters/ChatRoomsListAdapter.kt
View file

@ -58,7 +58,7 @@ class ChatRoomsListAdapter(
fun forwardPending(pending: Boolean) { fun forwardPending(pending: Boolean) {
isForwardPending = pending isForwardPending = pending
notifyDataSetChanged() notifyItemRangeChanged(0, itemCount)
} }
inner class ViewHolder( inner class ViewHolder(

2
app/src/main/java/org/linphone/activities/main/chat/adapters/GroupInfoParticipantsAdapter.kt
View file

@ -57,7 +57,7 @@ class GroupInfoParticipantsAdapter(
fun showAdminControls(show: Boolean) { fun showAdminControls(show: Boolean) {
showAdmin = show showAdmin = show
notifyDataSetChanged() notifyItemRangeChanged(0, itemCount)
} }
inner class ViewHolder( inner class ViewHolder(

2
app/src/main/java/org/linphone/activities/main/chat/fragments/MasterChatRoomsFragment.kt
View file

@ -223,7 +223,7 @@ class MasterChatRoomsFragment : MasterFragment<ChatRoomMasterFragmentBinding, Ch
viewLifecycleOwner viewLifecycleOwner
) { ) {
it.consume { it.consume {
adapter.notifyDataSetChanged() adapter.notifyItemRangeChanged(0, adapter.itemCount)
} }
} }

2
app/src/main/java/org/linphone/activities/main/files/fragments/PdfViewerFragment.kt
View file

@ -56,6 +56,6 @@ class PdfViewerFragment : GenericViewerFragment<FilePdfViewerFragmentBinding>()
adapter = PdfPagesListAdapter(viewModel) adapter = PdfPagesListAdapter(viewModel)
binding.pdfViewPager.adapter = adapter binding.pdfViewPager.adapter = adapter
adapter.notifyDataSetChanged() //adapter.notifyDataSetChanged()
} }
} }

2
app/src/main/java/org/linphone/activities/main/history/fragments/MasterCallLogsFragment.kt
View file

@ -202,7 +202,7 @@ class MasterCallLogsFragment : MasterFragment<HistoryMasterFragmentBinding, Call
viewLifecycleOwner viewLifecycleOwner
) { ) {
it.consume { it.consume {
adapter.notifyDataSetChanged() adapter.notifyItemRangeChanged(0, adapter.itemCount)
} }
} }

2
app/src/main/java/org/linphone/compatibility/Api25Compatibility.kt
View file

@ -19,6 +19,7 @@
*/ */
package org.linphone.compatibility package org.linphone.compatibility
import android.annotation.SuppressLint
import android.annotation.TargetApi import android.annotation.TargetApi
import android.bluetooth.BluetoothAdapter import android.bluetooth.BluetoothAdapter
import android.content.Context import android.content.Context
@ -29,6 +30,7 @@ import org.linphone.utils.ShortcutsHelper
@TargetApi(25) @TargetApi(25)
class Api25Compatibility { class Api25Compatibility {
companion object { companion object {
@SuppressLint("MissingPermission")
fun getDeviceName(context: Context): String { fun getDeviceName(context: Context): String {
var name = Settings.Global.getString( var name = Settings.Global.getString(
context.contentResolver, Settings.Global.DEVICE_NAME context.contentResolver, Settings.Global.DEVICE_NAME

54
app/src/main/res/layout-land/voip_conference_grid.xml
View file

@ -19,42 +19,36 @@
type="Integer" /> type="Integer" />
</data> </data>
<RelativeLayout <LinearLayout
android:layout_width="match_parent" android:layout_width="match_parent"
android:layout_height="match_parent" android:layout_height="match_parent"
android:layout_margin="@{controlsViewModel.fullScreenMode || controlsViewModel.pipMode ? @dimen/voip_remote_margin_full_screen : @dimen/voip_remote_margin, default=@dimen/voip_remote_margin}" android:layout_margin="@{controlsViewModel.fullScreenMode || controlsViewModel.pipMode ? @dimen/voip_remote_margin_full_screen : @dimen/voip_remote_margin, default=@dimen/voip_remote_margin}"
android:visibility="@{inflatedVisibility}"> android:visibility="@{inflatedVisibility}"
android:gravity="center"
android:orientation="vertical">
<LinearLayout <include
android:id="@+id/header"
layout="@layout/voip_conference_header"
android:visibility="@{controlsViewModel.fullScreenMode || controlsViewModel.pipMode ? View.GONE : View.VISIBLE}"
app:conferenceViewModel="@{conferenceViewModel}" />
<include
android:id="@+id/remote_recording"
layout="@layout/voip_remote_recording"
android:layout_width="match_parent"
android:layout_height="wrap_content"
android:visibility="@{conferenceViewModel.isRemotelyRecorded ? View.VISIBLE : View.GONE, default=gone}" />
<org.linphone.activities.voip.views.GridBoxLayout
centerContent="@{true}"
android:layout_width="match_parent" android:layout_width="match_parent"
android:layout_height="match_parent" android:layout_height="match_parent"
android:gravity="center" android:layout_marginTop="10dp"
android:orientation="vertical"> android:onClick="@{() -> controlsViewModel.toggleFullScreen()}"
app:entries="@{conferenceViewModel.conferenceParticipantDevices}"
app:layout="@{@layout/voip_conference_participant_remote_grid}" />
<include </LinearLayout>
android:id="@+id/header"
layout="@layout/voip_conference_header"
android:visibility="@{controlsViewModel.fullScreenMode || controlsViewModel.pipMode ? View.GONE : View.VISIBLE}"
app:conferenceViewModel="@{conferenceViewModel}" />
<include
android:id="@+id/remote_recording"
layout="@layout/voip_remote_recording"
android:layout_width="match_parent"
android:layout_height="wrap_content"
android:visibility="@{conferenceViewModel.isRemotelyRecorded ? View.VISIBLE : View.GONE, default=gone}" />
<org.linphone.activities.voip.views.GridBoxLayout
centerContent="@{true}"
android:layout_width="match_parent"
android:layout_height="match_parent"
android:layout_marginTop="10dp"
android:onClick="@{() -> controlsViewModel.toggleFullScreen()}"
app:entries="@{conferenceViewModel.conferenceParticipantDevices}"
app:layout="@{@layout/voip_conference_participant_remote_grid}" />
</LinearLayout>
</RelativeLayout>
</layout> </layout>

9
app/src/main/res/layout/conference_schedule_cell.xml
View file

@ -1,5 +1,6 @@
<?xml version="1.0" encoding="utf-8"?> <?xml version="1.0" encoding="utf-8"?>
<layout xmlns:android="http://schemas.android.com/apk/res/android" <layout xmlns:tools="http://schemas.android.com/tools"
xmlns:android="http://schemas.android.com/apk/res/android"
xmlns:app="http://schemas.android.com/apk/res-auto"> xmlns:app="http://schemas.android.com/apk/res-auto">
<data> <data>
@ -117,6 +118,7 @@
android:layout_width="wrap_content" android:layout_width="wrap_content"
android:layout_height="wrap_content" android:layout_height="wrap_content"
android:layout_marginEnd="10dp" android:layout_marginEnd="10dp"
android:contentDescription="@string/content_description_toggle_conference_info_details"
android:src="@drawable/button_conference_info"/> android:src="@drawable/button_conference_info"/>
</LinearLayout> </LinearLayout>
@ -139,6 +141,7 @@
android:layout_marginEnd="10dp" android:layout_marginEnd="10dp"
android:layout_marginBottom="10dp" android:layout_marginBottom="10dp"
android:selected="@{true}" android:selected="@{true}"
android:contentDescription="@string/content_description_toggle_conference_info_details"
android:src="@drawable/button_conference_info" /> android:src="@drawable/button_conference_info" />
<ImageView <ImageView
@ -147,6 +150,7 @@
android:layout_height="wrap_content" android:layout_height="wrap_content"
android:layout_alignParentTop="true" android:layout_alignParentTop="true"
android:layout_alignParentStart="true" android:layout_alignParentStart="true"
android:contentDescription="@string/content_description_conference_participants"
android:src="@drawable/icon_schedule_participants"/> android:src="@drawable/icon_schedule_participants"/>
<EditText <EditText
@ -161,7 +165,8 @@
android:drawablePadding="5dp" android:drawablePadding="5dp"
android:enabled="false" android:enabled="false"
android:inputType="textMultiLine" android:inputType="textMultiLine"
android:text="@{data.participantsExpanded}" /> android:text="@{data.participantsExpanded}"
tools:ignore="LabelFor" />
</RelativeLayout> </RelativeLayout>

6
app/src/main/res/layout/conference_scheduling_fragment.xml
View file

@ -142,7 +142,8 @@
<LinearLayout <LinearLayout
android:layout_width="match_parent" android:layout_width="match_parent"
android:layout_height="wrap_content" android:layout_height="wrap_content"
android:orientation="horizontal"> android:orientation="horizontal"
android:baselineAligned="false">
<LinearLayout <LinearLayout
android:layout_width="0dp" android:layout_width="0dp"
@ -203,7 +204,8 @@
<LinearLayout <LinearLayout
android:layout_width="match_parent" android:layout_width="match_parent"
android:layout_height="wrap_content" android:layout_height="wrap_content"
android:orientation="horizontal"> android:orientation="horizontal"
android:baselineAligned="false">
<LinearLayout <LinearLayout
android:layout_width="0dp" android:layout_width="0dp"

9
app/src/main/res/layout/conference_scheduling_summary_fragment.xml
View file

@ -110,7 +110,8 @@
android:layout_marginEnd="5dp" android:layout_marginEnd="5dp"
style="@style/conference_scheduling_font" style="@style/conference_scheduling_font"
android:background="?attr/voipFormDisabledFieldBackgroundColor" android:background="?attr/voipFormDisabledFieldBackgroundColor"
android:text="@{viewModel.subject}" /> android:text="@{viewModel.subject}"
bind:ignore="LabelFor" />
</LinearLayout> </LinearLayout>
@ -124,7 +125,8 @@
<LinearLayout <LinearLayout
android:layout_width="match_parent" android:layout_width="match_parent"
android:layout_height="wrap_content" android:layout_height="wrap_content"
android:orientation="horizontal"> android:orientation="horizontal"
android:baselineAligned="false">
<LinearLayout <LinearLayout
android:layout_width="0dp" android:layout_width="0dp"
@ -179,7 +181,8 @@
<LinearLayout <LinearLayout
android:layout_width="match_parent" android:layout_width="match_parent"
android:layout_height="wrap_content" android:layout_height="wrap_content"
android:orientation="horizontal"> android:orientation="horizontal"
android:baselineAligned="false">
<LinearLayout <LinearLayout
android:layout_width="0dp" android:layout_width="0dp"

3
app/src/main/res/layout/history_conf_detail_fragment.xml
View file

@ -74,7 +74,8 @@
android:layout_height="wrap_content" android:layout_height="wrap_content"
android:layout_marginStart="10dp" android:layout_marginStart="10dp"
android:layout_marginEnd="10dp" android:layout_marginEnd="10dp"
android:orientation="horizontal"> android:orientation="horizontal"
android:baselineAligned="false">
<LinearLayout <LinearLayout
android:layout_width="0dp" android:layout_width="0dp"

1
app/src/main/res/layout/voip_calls_cell.xml
View file

@ -42,6 +42,7 @@
android:layout_height="45dp" android:layout_height="45dp"
android:layout_marginLeft="40dp" android:layout_marginLeft="40dp"
android:layout_centerVertical="true" android:layout_centerVertical="true"
android:contentDescription="@null"
android:background="@drawable/generated_avatar_bg" android:background="@drawable/generated_avatar_bg"
android:src="@drawable/icon_multiple_contacts_avatar" /> android:src="@drawable/icon_multiple_contacts_avatar" />

3
app/src/main/res/layout/voip_conference_audio_only.xml
View file

@ -1,7 +1,6 @@
<?xml version="1.0" encoding="utf-8"?> <?xml version="1.0" encoding="utf-8"?>
<layout xmlns:android="http://schemas.android.com/apk/res/android" <layout xmlns:android="http://schemas.android.com/apk/res/android"
xmlns:app="http://schemas.android.com/apk/res-auto" xmlns:app="http://schemas.android.com/apk/res-auto">
xmlns:tools="http://schemas.android.com/tools">
<data> <data>

54
app/src/main/res/layout/voip_conference_grid.xml
View file

@ -19,42 +19,36 @@
type="Integer" /> type="Integer" />
</data> </data>
<RelativeLayout <LinearLayout
android:layout_width="match_parent" android:layout_width="match_parent"
android:layout_height="match_parent" android:layout_height="match_parent"
android:layout_margin="@{controlsViewModel.fullScreenMode || controlsViewModel.pipMode ? @dimen/voip_remote_margin_full_screen : @dimen/voip_remote_margin, default=@dimen/voip_remote_margin}" android:layout_margin="@{controlsViewModel.fullScreenMode || controlsViewModel.pipMode ? @dimen/voip_remote_margin_full_screen : @dimen/voip_remote_margin, default=@dimen/voip_remote_margin}"
android:visibility="@{inflatedVisibility}"> android:visibility="@{inflatedVisibility}"
android:gravity="center"
android:orientation="vertical">
<LinearLayout <include
android:id="@+id/header"
layout="@layout/voip_conference_header"
android:visibility="@{controlsViewModel.fullScreenMode || controlsViewModel.pipMode ? View.GONE : View.VISIBLE}"
app:conferenceViewModel="@{conferenceViewModel}" />
<include
android:id="@+id/remote_recording"
layout="@layout/voip_remote_recording"
android:layout_width="match_parent"
android:layout_height="wrap_content"
android:visibility="@{conferenceViewModel.isRemotelyRecorded ? View.VISIBLE : View.GONE, default=gone}" />
<org.linphone.activities.voip.views.GridBoxLayout
centerContent="@{true}"
android:layout_width="match_parent" android:layout_width="match_parent"
android:layout_height="match_parent" android:layout_height="match_parent"
android:gravity="center" android:layout_marginTop="10dp"
android:orientation="vertical"> android:onClick="@{() -> controlsViewModel.toggleFullScreen()}"
app:entries="@{conferenceViewModel.conferenceParticipantDevices}"
app:layout="@{@layout/voip_conference_participant_remote_grid}" />
<include </LinearLayout>
android:id="@+id/header"
layout="@layout/voip_conference_header"
android:visibility="@{controlsViewModel.fullScreenMode || controlsViewModel.pipMode ? View.GONE : View.VISIBLE}"
app:conferenceViewModel="@{conferenceViewModel}" />
<include
android:id="@+id/remote_recording"
layout="@layout/voip_remote_recording"
android:layout_width="match_parent"
android:layout_height="wrap_content"
android:visibility="@{conferenceViewModel.isRemotelyRecorded ? View.VISIBLE : View.GONE, default=gone}" />
<org.linphone.activities.voip.views.GridBoxLayout
centerContent="@{true}"
android:layout_width="match_parent"
android:layout_height="match_parent"
android:layout_marginTop="10dp"
android:onClick="@{() -> controlsViewModel.toggleFullScreen()}"
app:entries="@{conferenceViewModel.conferenceParticipantDevices}"
app:layout="@{@layout/voip_conference_participant_remote_grid}" />
</LinearLayout>
</RelativeLayout>
</layout> </layout>

8
app/src/main/res/values-fr/strings.xml
View file

@ -470,7 +470,7 @@
<string name="assistant_validate_account_1">Votre compte a été créé. Nous vous avons envoyé un email de confirmation à l\'adresse :</string> <string name="assistant_validate_account_1">Votre compte a été créé. Nous vous avons envoyé un email de confirmation à l\'adresse :</string>
<plurals name="chat_room_remote_composing"> <plurals name="chat_room_remote_composing">
<item quantity="one">%s écrit…</item> <item quantity="one">%s écrit…</item>
<item quantity="other">%s écrivent…</item> <item quantity="many">%s écrivent…</item>
</plurals> </plurals>
<string name="chat_event_participant_added">%s a rejoint le groupe</string> <string name="chat_event_participant_added">%s a rejoint le groupe</string>
<string name="contact_choose_existing_or_new_to_add_number">Sélectionnez un contact ou créez-en un</string> <string name="contact_choose_existing_or_new_to_add_number">Sélectionnez un contact ou créez-en un</string>
@ -480,7 +480,7 @@
<string name="sip_addresses">Adresses SIP</string> <string name="sip_addresses">Adresses SIP</string>
<plurals name="days"> <plurals name="days">
<item quantity="one">%d jour</item> <item quantity="one">%d jour</item>
<item quantity="other">%d jours</item> <item quantity="many">%d jours</item>
</plurals> </plurals>
<string name="contact_delete_one_dialog">Voulez-vous supprimer ce contact \?\nIl sera aussi retiré du carnet d\'adresses du téléphone.</string> <string name="contact_delete_one_dialog">Voulez-vous supprimer ce contact \?\nIl sera aussi retiré du carnet d\'adresses du téléphone.</string>
<string name="dialer_address_bar_hint">Entrez un numéro ou une adresse</string> <string name="dialer_address_bar_hint">Entrez un numéro ou une adresse</string>
@ -578,7 +578,7 @@
<string name="call_settings_use_telecom_manager_summary">Nécessite des permissions supplémentaires</string> <string name="call_settings_use_telecom_manager_summary">Nécessite des permissions supplémentaires</string>
<plurals name="chat_room_unread_messages_event"> <plurals name="chat_room_unread_messages_event">
<item quantity="one">%1$d message non lu</item> <item quantity="one">%1$d message non lu</item>
<item quantity="other">%1$d messages non lus</item> <item quantity="many">%1$d messages non lus</item>
</plurals> </plurals>
<string name="content_descripton_scroll_to_bottom">Aller au dernier message reçu ou au premier message non lu</string> <string name="content_descripton_scroll_to_bottom">Aller au dernier message reçu ou au premier message non lu</string>
<string name="audio_settings_prefer_bluetooth_devices_title">Acheminer l\'audio vers l\'appareil bluetooth, s\'il existe</string> <string name="audio_settings_prefer_bluetooth_devices_title">Acheminer l\'audio vers l\'appareil bluetooth, s\'il existe</string>
@ -719,4 +719,6 @@
<string name="conference_participant_paused">(en pause)</string> <string name="conference_participant_paused">(en pause)</string>
<string name="content_description_take_screenshot">Prendre une capture de la vidéo reçue</string> <string name="content_description_take_screenshot">Prendre une capture de la vidéo reçue</string>
<string name="conference_low_bandwidth">Faible bande passante détectée, vidéo désactivée</string> <string name="conference_low_bandwidth">Faible bande passante détectée, vidéo désactivée</string>
<string name="content_description_toggle_conference_info_details">Afficher/cacher les détails de la conférence</string>
<string name="content_description_conference_participants">Participants de la conférence</string>
</resources> </resources>

2
app/src/main/res/values/strings.xml
View file

@ -849,4 +849,6 @@
<string name="content_description_conference_participant_mic_muted">Participant has it\'s microphone muted</string> <string name="content_description_conference_participant_mic_muted">Participant has it\'s microphone muted</string>
<string name="content_description_toggle_layout_menu">Show or hide conference layout menu</string> <string name="content_description_toggle_layout_menu">Show or hide conference layout menu</string>
<string name="content_description_participant_is_paused">Participant has momentarily left the conference</string> <string name="content_description_participant_is_paused">Participant has momentarily left the conference</string>
<string name="content_description_toggle_conference_info_details">Toggle conference information details visibility</string>
<string name="content_description_conference_participants">Conference participants</string>
</resources> </resources>