From 1eadb5bc8174e1b4e1eb37353b2c6d2436b9b1c6 Mon Sep 17 00:00:00 2001
From: Sylvain Berfini <Sylvain.Berfini@Belledonne-Communications.com>
Date: Thu, 12 Apr 2012 12:28:45 +0200
Subject: [PATCH] fix switch camera issue + add call button

---
 res/layout-xlarge/dialer.xml            | 30 +++++++++-
 res/layout-xlarge/videocall.xml         |  3 +-
 src/org/linphone/DialerActivity.java    | 77 ++++++++++++++++++++++---
 src/org/linphone/IncallActivity.java    |  2 +-
 src/org/linphone/VideoCallActivity.java | 10 +++-
 5 files changed, 106 insertions(+), 16 deletions(-)

diff --git a/res/layout-xlarge/dialer.xml b/res/layout-xlarge/dialer.xml
index 725839d8d..9d0dbba6a 100644
--- a/res/layout-xlarge/dialer.xml
+++ b/res/layout-xlarge/dialer.xml
@@ -58,7 +58,7 @@
 				android:layout_weight="0.5" 
 			    android:layout_marginLeft="40dp"
 		    	android:orientation="vertical">
-		    
+					
 				<org.linphone.ui.CallButton 
 				    android:id="@+id/Call"
 					android:layout_height="fill_parent" 
@@ -67,12 +67,38 @@
 					android:background="@drawable/clavier_bg" 
 					android:src="@drawable/startcall_green" />
 				
+	            <LinearLayout
+				    android:id="@+id/InCallControls"
+					android:layout_height="fill_parent" 
+					android:layout_width="fill_parent" 
+					android:visibility="gone"
+					android:layout_weight="3" >
+					
+	                <Button 
+					    android:id="@+id/AddCall"
+					    style="@style/DialerDigit"
+						android:layout_height="fill_parent" 
+						android:layout_width="fill_parent" 
+						android:layout_weight="1" 
+						android:text="@string/AddCallButtonText" />
+	                
+					<Button 
+					    android:id="@+id/Back"
+					    style="@style/DialerDigit"
+						android:layout_height="fill_parent" 
+						android:layout_width="fill_parent" 
+						android:layout_weight="1" 
+						android:text="@string/CancelButtonText" />
+					
+				</LinearLayout>
+				
 				<Button 
-				    style="@style/DialerDigit"
 				    android:id="@+id/switch_camera"
+				    style="@style/DialerDigit"
 					android:layout_height="fill_parent" 
 					android:layout_width="fill_parent" 
 					android:layout_weight="5" 
+					android:visibility="invisible"
 					android:text="@string/menu_videocall_switch_camera_title" />
 				
 			    <EditText 
diff --git a/res/layout-xlarge/videocall.xml b/res/layout-xlarge/videocall.xml
index bca2c97a9..b5b8f178f 100755
--- a/res/layout-xlarge/videocall.xml
+++ b/res/layout-xlarge/videocall.xml
@@ -57,7 +57,8 @@
 			android:orientation="vertical">
 	        
 	        <Button 
-			    style="@style/incall_control"
+	            style="@style/incall_control"
+	            android:background="@drawable/clavier_bg"
 			    android:id="@+id/switch_camera"
 				android:layout_height="wrap_content" 
 				android:layout_width="fill_parent" 
diff --git a/src/org/linphone/DialerActivity.java b/src/org/linphone/DialerActivity.java
index 47c9db12d..ed6a7203a 100644
--- a/src/org/linphone/DialerActivity.java
+++ b/src/org/linphone/DialerActivity.java
@@ -25,8 +25,10 @@ import org.linphone.LinphoneService.LinphoneGuiListener;
 import org.linphone.core.LinphoneCall;
 import org.linphone.core.LinphoneCall.State;
 import org.linphone.core.LinphoneCore.RegistrationState;
+import org.linphone.core.LinphoneCoreException;
 import org.linphone.core.LinphoneProxyConfig;
 import org.linphone.core.Log;
+import org.linphone.mediastream.video.capture.hwconf.AndroidCameraConfiguration;
 import org.linphone.ui.AddressAware;
 import org.linphone.ui.AddressText;
 import org.linphone.ui.CallButton;
@@ -49,6 +51,7 @@ import android.view.View;
 import android.view.View.OnClickListener;
 import android.widget.Adapter;
 import android.widget.Button;
+import android.widget.LinearLayout;
 import android.widget.ListAdapter;
 import android.widget.ListView;
 import android.widget.SimpleAdapter;
@@ -75,6 +78,8 @@ public class DialerActivity extends Activity implements LinphoneGuiListener {
 
 	private AddressText mAddress;
 	private CallButton mCall;
+	private Button mBack, mAddCall, mSwitchCamera;
+	private LinearLayout mInCallControls;
 
 	private static DialerActivity instance;
 	private boolean mPreventDoubleCallOnRotation;
@@ -87,6 +92,7 @@ public class DialerActivity extends Activity implements LinphoneGuiListener {
 	private int mCurrentCameraId = 0;
 
 	private Camera mCamera;
+
 	
 	private static final String CURRENT_ADDRESS = "org.linphone.current-address"; 
 	private static final String CURRENT_DISPLAYNAME = "org.linphone.current-displayname";
@@ -206,10 +212,12 @@ public class DialerActivity extends Activity implements LinphoneGuiListener {
 
 		mCall = (CallButton) findViewById(R.id.Call);
 		mCall.setAddressWidget(mAddress);
-
+		mBack = (Button) findViewById(R.id.Back);
+		mAddCall = (Button) findViewById(R.id.AddCall);
+		mInCallControls = (LinearLayout) findViewById(R.id.InCallControls);
 		mStatus =  (TextView) findViewById(R.id.status_label);
         
-		tryToInitTablerUI();
+		tryToInitTabletUI();
 		
 		SlidingDrawer drawer = (SlidingDrawer) findViewById(R.id.drawer);
 		if (drawer != null) {
@@ -250,7 +258,7 @@ public class DialerActivity extends Activity implements LinphoneGuiListener {
 	}
 
 
-    private synchronized void tryToInitTablerUI() {
+    private synchronized void tryToInitTabletUI() {
 		final int numberOfCameras = Camera.getNumberOfCameras();
 		
         CameraInfo cameraInfo = new CameraInfo();
@@ -271,13 +279,13 @@ public class DialerActivity extends Activity implements LinphoneGuiListener {
 			mCamera.startPreview();
 		}
 		
-		Button switchCamera = (Button) findViewById(R.id.switch_camera);
-		if (switchCamera != null)
+		mSwitchCamera = (Button) findViewById(R.id.switch_camera);
+		if (mSwitchCamera != null)
 		{
-			if (numberOfCameras == 1)
-				switchCamera.setVisibility(View.INVISIBLE);
+			if (AndroidCameraConfiguration.hasSeveralCameras())
+				mSwitchCamera.setVisibility(View.VISIBLE);
 			
-			switchCamera.setOnClickListener(new OnClickListener() {
+			mSwitchCamera.setOnClickListener(new OnClickListener() {
 				public void onClick(View v) {
 					mCurrentCameraId = (mCurrentCameraId + 1) % numberOfCameras;
 					mCamera.release();
@@ -289,6 +297,34 @@ public class DialerActivity extends Activity implements LinphoneGuiListener {
 				}
 			});
 		}
+		
+		mBack.setOnClickListener(new OnClickListener() {
+			public void onClick(View v) {
+				LinphoneCall call = LinphoneManager.getLc().getCurrentCall();
+				if (call.getCurrentParamsCopy().getVideoEnabled())
+					LinphoneActivity.instance().startVideoActivity(call, 0);
+				else
+					LinphoneActivity.instance().startIncallActivity();
+			}
+		});
+		
+		mAddCall.setOnClickListener(new OnClickListener() {
+			public void onClick(View v) {
+				LinphoneCall call = LinphoneManager.getLc().getCurrentCall();
+				if (call != null && !call.isInConference()) {
+					LinphoneManager.getLc().pauseCall(call);
+				} else {
+					LinphoneManager.getLc().leaveConference();
+				}
+					
+				try {
+					LinphoneManager.getLc().invite(mAddress.getText().toString());
+				} catch (LinphoneCoreException e) {
+					Log.e(e);
+					Toast.makeText(DialerActivity.this, R.string.error_adding_new_call, Toast.LENGTH_LONG).show();
+				}
+			}
+		});
 	}
 
 	private void checkIfOutgoingCallIntentReceived() {
@@ -423,7 +459,20 @@ public class DialerActivity extends Activity implements LinphoneGuiListener {
 	}
 
 	@Override
-	public void onCallStateChanged(LinphoneCall call, State s, String m) {}
+	public void onCallStateChanged(LinphoneCall call, State s, String m) {
+		if (mVideoCaptureView != null && mCamera == null && !LinphoneManager.getLc().isIncall())
+		{
+			mInCallControls.setVisibility(View.GONE);
+			mCall.setVisibility(View.VISIBLE);
+			
+			if (AndroidCameraConfiguration.hasSeveralCameras())
+				mSwitchCamera.setVisibility(View.VISIBLE);
+			
+			mCamera = Camera.open(mCurrentCameraId);
+			mVideoCaptureView.switchCamera(mCamera, mCurrentCameraId);
+			mCamera.startPreview();
+		}
+	}
 	
 	public void onGlobalStateChangedToOn(String message) {
 		mCall.setEnabled(!LinphoneManager.getLc().isIncall());
@@ -445,11 +494,21 @@ public class DialerActivity extends Activity implements LinphoneGuiListener {
         
 		super.onResume();
 		
+		mInCallControls.setVisibility(View.GONE);
+		mCall.setVisibility(View.VISIBLE);
+		if (AndroidCameraConfiguration.hasSeveralCameras())
+			mSwitchCamera.setVisibility(View.VISIBLE);
+		
 		if (mVideoCaptureView != null && mCamera == null && !LinphoneManager.getLc().isIncall())
 		{
 			mCamera = Camera.open(mCurrentCameraId);
 			mVideoCaptureView.switchCamera(mCamera, mCurrentCameraId);
 			mCamera.startPreview();
+		} else if (LinphoneManager.getLc().isIncall())
+		{
+			mInCallControls.setVisibility(View.VISIBLE);
+			mCall.setVisibility(View.GONE);
+			mSwitchCamera.setVisibility(View.INVISIBLE);
 		}
 	}
 
diff --git a/src/org/linphone/IncallActivity.java b/src/org/linphone/IncallActivity.java
index 216e5da25..5499a4ce0 100644
--- a/src/org/linphone/IncallActivity.java
+++ b/src/org/linphone/IncallActivity.java
@@ -324,7 +324,7 @@ public class IncallActivity extends AbstractCalleesActivity implements
 	public void onClick(View v) {
 		switch (v.getId()) {
 		case R.id.addCall:
-			openUriPicker(UriPickerActivity.EXTRA_PICKER_TYPE_ADD, addCallId);
+			finish();
 			break;
 		case R.id.incallHang:
 			terminateCurrentCallOrConferenceOrAll();
diff --git a/src/org/linphone/VideoCallActivity.java b/src/org/linphone/VideoCallActivity.java
index 1d7e4758f..4dec1712b 100755
--- a/src/org/linphone/VideoCallActivity.java
+++ b/src/org/linphone/VideoCallActivity.java
@@ -166,6 +166,7 @@ public class VideoCallActivity extends Activity implements LinphoneOnCallStateCh
 			findViewById(R.id.toggleMuteMic).setOnClickListener(this);
 			findViewById(R.id.toggleSpeaker).setOnClickListener(this);
 			findViewById(R.id.incallNumpadShow).setOnClickListener(this);
+			findViewById(R.id.addCall).setOnClickListener(this);
 			findViewById(R.id.incallHang).setOnClickListener(this);
 			findViewById(R.id.switch_camera).setOnClickListener(this);
 			findViewById(R.id.conf_simple_pause).setOnClickListener(this);
@@ -256,10 +257,10 @@ public class VideoCallActivity extends Activity implements LinphoneOnCallStateCh
 		if (mControlsLayout != null)
 			mControlsLayout.setVisibility(View.GONE);
 	}
-
-	@Override
+	
 	public boolean onKeyDown(int keyCode, KeyEvent event) {
 		if (LinphoneUtils.onKeyVolumeSoftAdjust(keyCode)) return true;
+		if (LinphoneUtils.onKeyBackGoHome(this, keyCode, event)) return true;
 		return super.onKeyDown(keyCode, event);
 	}
 
@@ -372,7 +373,7 @@ public class VideoCallActivity extends Activity implements LinphoneOnCallStateCh
 			case R.id.toggleMuteMic:
 				LinphoneManager.getLc().muteMic(((Checkable) v).isChecked());
 				break;
-			case R.id.videocall_menu_switch_camera:
+			case R.id.switch_camera:
 				int id = LinphoneManager.getLc().getVideoDevice();
 				id = (id + 1) % AndroidCameraConfiguration.retrieveCameras().length;
 				LinphoneManager.getLc().setVideoDevice(id);
@@ -392,6 +393,9 @@ public class VideoCallActivity extends Activity implements LinphoneOnCallStateCh
 				params.setVideoEnabled(false);
 				LinphoneManager.getLc().updateCall(videoCall, params);
 				break;	
+			case R.id.addCall:
+				finish();
+				break;
 		}
 	}