From 10e29db30294132b56fecbf8e9b097738750241b Mon Sep 17 00:00:00 2001 From: Sylvain Berfini Date: Fri, 7 Apr 2023 11:04:35 +0200 Subject: [PATCH] Added / improved some logs --- .../java/org/linphone/activities/main/MainActivity.kt | 2 +- .../main/chat/fragments/DetailChatRoomFragment.kt | 1 + app/src/main/java/org/linphone/utils/AppUtils.kt | 10 +++++++--- 3 files changed, 9 insertions(+), 4 deletions(-) diff --git a/app/src/main/java/org/linphone/activities/main/MainActivity.kt b/app/src/main/java/org/linphone/activities/main/MainActivity.kt index 36790c307..49c758bab 100644 --- a/app/src/main/java/org/linphone/activities/main/MainActivity.kt +++ b/app/src/main/java/org/linphone/activities/main/MainActivity.kt @@ -205,7 +205,7 @@ class MainActivity : GenericActivity(), SnackBarActivity, NavController.OnDestin binding.rootCoordinatorLayout.addKeyboardInsetListener { keyboardVisible -> val portraitOrientation = resources.configuration.orientation != Configuration.ORIENTATION_LANDSCAPE - Log.d("[Tabs Fragment] Keyboard is ${if (keyboardVisible) "visible" else "invisible"}") + Log.i("[Main Activity] Keyboard is ${if (keyboardVisible) "visible" else "invisible"}, orientation is ${if (portraitOrientation) "portrait" else "landscape"}") shouldTabsBeVisibleDueToOrientationAndKeyboard = !portraitOrientation || !keyboardVisible updateTabsFragmentVisibility() } diff --git a/app/src/main/java/org/linphone/activities/main/chat/fragments/DetailChatRoomFragment.kt b/app/src/main/java/org/linphone/activities/main/chat/fragments/DetailChatRoomFragment.kt index c9307db1a..f09d1f85b 100644 --- a/app/src/main/java/org/linphone/activities/main/chat/fragments/DetailChatRoomFragment.kt +++ b/app/src/main/java/org/linphone/activities/main/chat/fragments/DetailChatRoomFragment.kt @@ -192,6 +192,7 @@ class DetailChatRoomFragment : MasterFragment if (keyboardVisible && chatSendingViewModel.isEmojiPickerOpen.value == true) { + Log.d("[Chat Room] Emoji picker is opened, closing it because keyboard is now visible") chatSendingViewModel.isEmojiPickerOpen.value = false } } diff --git a/app/src/main/java/org/linphone/utils/AppUtils.kt b/app/src/main/java/org/linphone/utils/AppUtils.kt index 5f94a1b72..8b43b3bbd 100644 --- a/app/src/main/java/org/linphone/utils/AppUtils.kt +++ b/app/src/main/java/org/linphone/utils/AppUtils.kt @@ -87,6 +87,7 @@ class AppUtils { if (emoji?.hasEmojiGlyph(split[i]) == true) { val glyph = emoji.process(split[i]) if (characters > 0) { // Limit initial to 1 emoji only + Log.d("[App Utils] We limit initials to one emoji only") initials = "" } initials += glyph @@ -113,17 +114,20 @@ class AppUtils { try { for (split in text.split(" ")) { // We only check the first and last chars of the split for commodity - if (emoji.getEmojiStart(split, 0) == -1 - || emoji.getEmojiEnd(split,split.length - 1) == -1) - { + if (emoji.getEmojiStart(split, 0) == -1 || + emoji.getEmojiEnd(split, split.length - 1) == -1 + ) { + Log.d("[App Utils] Found a non-emoji character in [$text]") return false } } } catch (npe: NullPointerException) { + Log.e("[App Utils] Can't check emoji presence in text due to NPE in EmojiCompat library, assuming there is none") // This can happen in EmojiCompat library, mProcessor can be null (https://issuetracker.google.com/issues/277182750) return false } + Log.d("[App Utils] It seems text [$text] only contains emoji(s)") return true }