Fix crash when username or domain is null

This commit is contained in:
Margaux Clerc 2014-09-05 10:13:12 +02:00
parent 6dc5194656
commit 03bd0e5c7b

View file

@ -65,9 +65,14 @@ public class AccountPreferencesFragment extends PreferencesListFragment {
manageAccountPreferencesFields(screen); manageAccountPreferencesFields(screen);
} }
public static boolean isEditTextEmpty(String s){
return s.equals(""); // really empty.
}
OnPreferenceChangeListener usernameChangedListener = new OnPreferenceChangeListener() { OnPreferenceChangeListener usernameChangedListener = new OnPreferenceChangeListener() {
@Override @Override
public boolean onPreferenceChange(Preference preference, Object newValue) { public boolean onPreferenceChange(Preference preference, Object newValue) {
if(isEditTextEmpty(newValue.toString())) return false;
mPrefs.setAccountUsername(n, newValue.toString()); mPrefs.setAccountUsername(n, newValue.toString());
preference.setSummary(newValue.toString()); preference.setSummary(newValue.toString());
return true; return true;
@ -84,6 +89,7 @@ public class AccountPreferencesFragment extends PreferencesListFragment {
OnPreferenceChangeListener passwordChangedListener = new OnPreferenceChangeListener() { OnPreferenceChangeListener passwordChangedListener = new OnPreferenceChangeListener() {
@Override @Override
public boolean onPreferenceChange(Preference preference, Object newValue) { public boolean onPreferenceChange(Preference preference, Object newValue) {
if(isEditTextEmpty(newValue.toString())) return false;
mPrefs.setAccountPassword(n, newValue.toString()); mPrefs.setAccountPassword(n, newValue.toString());
return true; return true;
} }
@ -91,6 +97,7 @@ public class AccountPreferencesFragment extends PreferencesListFragment {
OnPreferenceChangeListener domainChangedListener = new OnPreferenceChangeListener() { OnPreferenceChangeListener domainChangedListener = new OnPreferenceChangeListener() {
@Override @Override
public boolean onPreferenceChange(Preference preference, Object newValue) { public boolean onPreferenceChange(Preference preference, Object newValue) {
if(isEditTextEmpty(newValue.toString())) return false;
mPrefs.setAccountDomain(n, newValue.toString()); mPrefs.setAccountDomain(n, newValue.toString());
preference.setSummary(newValue.toString()); preference.setSummary(newValue.toString());
return true; return true;