Difuse/difuse-phone-android
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

Fixed chat room not marked as read when going in it if number of messages is not enough to make the list scrollable

Browse source
This commit is contained in:
Sylvain Berfini 2022-07-01 17:10:37 +02:00
parent b266f98593
commit 0327928bb1
1 changed files with 12 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

17
app/src/main/java/org/linphone/activities/main/chat/fragments/DetailChatRoomFragment.kt
View file

@ -1029,9 +1029,12 @@ class DetailChatRoomFragment : MasterFragment<ChatRoomDetailFragmentBinding, Cha
private fun scrollToFirstUnreadMessageOrBottom(smooth: Boolean): Boolean { private fun scrollToFirstUnreadMessageOrBottom(smooth: Boolean): Boolean {
if (_adapter != null && adapter.itemCount > 0) { if (_adapter != null && adapter.itemCount > 0) {
// Scroll to first unread message if any val recyclerView = binding.chatMessagesList
// Scroll to first unread message if any, unless we are already on it
val firstUnreadMessagePosition = adapter.getFirstUnreadMessagePosition() val firstUnreadMessagePosition = adapter.getFirstUnreadMessagePosition()
val indexToScrollTo = if (firstUnreadMessagePosition != -1) { val currentPosition = (recyclerView.layoutManager as LinearLayoutManager).findFirstCompletelyVisibleItemPosition()
val indexToScrollTo = if (firstUnreadMessagePosition != -1 && firstUnreadMessagePosition != currentPosition) {
firstUnreadMessagePosition firstUnreadMessagePosition
} else { } else {
adapter.itemCount - 1 adapter.itemCount - 1
@ -1039,11 +1042,15 @@ class DetailChatRoomFragment : MasterFragment<ChatRoomDetailFragmentBinding, Cha
Log.i("[Chat Room] Scrolling to position $indexToScrollTo, first unread message is at $firstUnreadMessagePosition") Log.i("[Chat Room] Scrolling to position $indexToScrollTo, first unread message is at $firstUnreadMessagePosition")
if (smooth && corePreferences.enableAnimations) { if (smooth && corePreferences.enableAnimations) {
binding.chatMessagesList.smoothScrollToPosition(indexToScrollTo) recyclerView.smoothScrollToPosition(indexToScrollTo)
} else { } else {
binding.chatMessagesList.scrollToPosition(indexToScrollTo) recyclerView.scrollToPosition(indexToScrollTo)
}
if (firstUnreadMessagePosition == 0) {
// Return true only if all unread messages don't fit in the recyclerview height
return recyclerView.computeVerticalScrollRange() > recyclerView.height
} }
return firstUnreadMessagePosition == 0
} }
return false return false
} }