Some checks failed
Build all core packages / Build all core packages for selected target (push) Waiting to run
Build and Push prebuilt tools container / Build and Push all prebuilt containers (push) Has been cancelled
Build Toolchains / Build Toolchains for each target (push) Has been cancelled
These instructions are for 64-bit load/store. On ARMv5TE, the CPU requires addresses to be aligned to 64-bit. When misaligned, behavior is undefined (effectively either loads the same word twice on LDRD, or corrupts surrounding memory on STRD). On ARMv6 and newer, unaligned access is safe. Removing these instructions for ARMv5TE is necessary, because GCC ignores alignment information in pointers and does unsafe optimizations that have shown up as bugs in various places. This patch was originally added more than 11 years ago in commitb050f87d13
, but got lost 6 years ago, when gcc 9.1 was added in88c07c6552
. This primarily affects the kirkwood and ixp4xx targets Signed-off-by: Felix Fietkau <nbd@nbd.name>
11 lines
426 B
Diff
11 lines
426 B
Diff
--- a/gcc/config/arm/arm.h
|
|
+++ b/gcc/config/arm/arm.h
|
|
@@ -165,7 +165,7 @@ emission of floating point pcs attribute
|
|
/* Thumb-1 only. */
|
|
#define TARGET_THUMB1_ONLY (TARGET_THUMB1 && !arm_arch_notm)
|
|
|
|
-#define TARGET_LDRD (arm_arch5te && ARM_DOUBLEWORD_ALIGN \
|
|
+#define TARGET_LDRD (arm_arch6 && ARM_DOUBLEWORD_ALIGN \
|
|
&& !TARGET_THUMB1)
|
|
|
|
#define TARGET_CRC32 (arm_arch_crc)
|