456b7a5d48
This is an automatically generated commit which aids following Kernel patch history, as git will see the move and copy as a rename thus defeating the purpose. For the original discussion see: https://lists.openwrt.org/pipermail/openwrt-devel/2023-October/041673.html Signed-off-by: Mieczyslaw Nalewaj <namiltd@yahoo.com> Link: https://github.com/openwrt/openwrt/pull/16547 Signed-off-by: Christian Marangi <ansuelsmth@gmail.com>
58 lines
1.9 KiB
Diff
58 lines
1.9 KiB
Diff
From eb89c79c1b8f17fc1611540768678e60df89ac42 Mon Sep 17 00:00:00 2001
|
|
From: Daniel Golle <daniel@makrotopia.org>
|
|
Date: Thu, 10 Oct 2024 13:55:17 +0100
|
|
Subject: [PATCH 3/4] net: phy: mxl-gpy: correctly describe LED polarity
|
|
|
|
According the datasheet covering the LED (0x1b) register:
|
|
0B Active High LEDx pin driven high when activated
|
|
1B Active Low LEDx pin driven low when activated
|
|
|
|
Make use of the now available 'active-high' property and correctly
|
|
reflect the polarity setting which was previously inverted.
|
|
|
|
Signed-off-by: Daniel Golle <daniel@makrotopia.org>
|
|
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
|
|
Link: https://patch.msgid.link/180ccafa837f09908b852a8a874a3808c5ecd2d0.1728558223.git.daniel@makrotopia.org
|
|
Signed-off-by: Paolo Abeni <pabeni@redhat.com>
|
|
---
|
|
drivers/net/phy/mxl-gpy.c | 16 ++++++++++++----
|
|
1 file changed, 12 insertions(+), 4 deletions(-)
|
|
|
|
--- a/drivers/net/phy/mxl-gpy.c
|
|
+++ b/drivers/net/phy/mxl-gpy.c
|
|
@@ -981,7 +981,7 @@ static int gpy_led_hw_control_set(struct
|
|
static int gpy_led_polarity_set(struct phy_device *phydev, int index,
|
|
unsigned long modes)
|
|
{
|
|
- bool active_low = false;
|
|
+ bool force_active_low = false, force_active_high = false;
|
|
u32 mode;
|
|
|
|
if (index >= GPY_MAX_LEDS)
|
|
@@ -990,15 +990,23 @@ static int gpy_led_polarity_set(struct p
|
|
for_each_set_bit(mode, &modes, __PHY_LED_MODES_NUM) {
|
|
switch (mode) {
|
|
case PHY_LED_ACTIVE_LOW:
|
|
- active_low = true;
|
|
+ force_active_low = true;
|
|
+ break;
|
|
+ case PHY_LED_ACTIVE_HIGH:
|
|
+ force_active_high = true;
|
|
break;
|
|
default:
|
|
return -EINVAL;
|
|
}
|
|
}
|
|
|
|
- return phy_modify(phydev, PHY_LED, PHY_LED_POLARITY(index),
|
|
- active_low ? 0 : PHY_LED_POLARITY(index));
|
|
+ if (force_active_low)
|
|
+ return phy_set_bits(phydev, PHY_LED, PHY_LED_POLARITY(index));
|
|
+
|
|
+ if (force_active_high)
|
|
+ return phy_clear_bits(phydev, PHY_LED, PHY_LED_POLARITY(index));
|
|
+
|
|
+ unreachable();
|
|
}
|
|
|
|
static struct phy_driver gpy_drivers[] = {
|