8f9e91ad03
These patches were generated from: https://github.com/raspberrypi/linux/commits/rpi-6.12.y With the following command: git format-patch -N v6.12.27..HEAD (HEAD -> 8d3206ee456a5ecdf9ddbfd8e5e231e4f0cd716e) Exceptions: - (def)configs patches - github workflows patches - applied & reverted patches - readme patches - wireless patches Signed-off-by: Álvaro Fernández Rojas <noltari@gmail.com>
71 lines
2.7 KiB
Diff
71 lines
2.7 KiB
Diff
From c19ceb223e1be775b54df5a27fcf19f0a5ca4727 Mon Sep 17 00:00:00 2001
|
|
From: Dave Stevenson <dave.stevenson@raspberrypi.com>
|
|
Date: Wed, 20 Nov 2024 19:17:03 +0000
|
|
Subject: [PATCH] media: i2c: imx290: Limit analogue gain according to module
|
|
|
|
Commit ec75fd952b0b5cdab7b606cdacba237c57c1fdda upstream.
|
|
|
|
The imx327 only supports up to 29.4dB of analogue gain, vs
|
|
the imx290 going up to 30dB. Both are in 0.3dB steps.
|
|
|
|
As we now have model specific config, fix this mismatch,
|
|
and delete the comment referencing it.
|
|
|
|
Signed-off-by: Dave Stevenson <dave.stevenson@raspberrypi.com>
|
|
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
|
|
Reviewed-by: Alexander Stein <alexander.stein@ew.tq-group.com>
|
|
Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
|
|
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
|
|
---
|
|
drivers/media/i2c/imx290.c | 12 ++++++------
|
|
1 file changed, 6 insertions(+), 6 deletions(-)
|
|
|
|
--- a/drivers/media/i2c/imx290.c
|
|
+++ b/drivers/media/i2c/imx290.c
|
|
@@ -178,6 +178,7 @@ struct imx290_model_info {
|
|
enum imx290_colour_variant colour_variant;
|
|
const struct cci_reg_sequence *init_regs;
|
|
size_t init_regs_num;
|
|
+ unsigned int max_analog_gain;
|
|
const char *name;
|
|
};
|
|
|
|
@@ -879,14 +880,10 @@ static int imx290_ctrl_init(struct imx29
|
|
* up to 72.0dB (240) add further digital gain. Limit the range to
|
|
* analog gain only, support for digital gain can be added separately
|
|
* if needed.
|
|
- *
|
|
- * The IMX327 and IMX462 are largely compatible with the IMX290, but
|
|
- * have an analog gain range of 0.0dB to 29.4dB and 42dB of digital
|
|
- * gain. When support for those sensors gets added to the driver, the
|
|
- * gain control should be adjusted accordingly.
|
|
*/
|
|
v4l2_ctrl_new_std(&imx290->ctrls, &imx290_ctrl_ops,
|
|
- V4L2_CID_ANALOGUE_GAIN, 0, 100, 1, 0);
|
|
+ V4L2_CID_ANALOGUE_GAIN, 0,
|
|
+ imx290->model->max_analog_gain, 1, 0);
|
|
|
|
/*
|
|
* Correct range will be determined through imx290_ctrl_update setting
|
|
@@ -1441,18 +1438,21 @@ static const struct imx290_model_info im
|
|
.colour_variant = IMX290_VARIANT_COLOUR,
|
|
.init_regs = imx290_global_init_settings_290,
|
|
.init_regs_num = ARRAY_SIZE(imx290_global_init_settings_290),
|
|
+ .max_analog_gain = 100,
|
|
.name = "imx290",
|
|
},
|
|
[IMX290_MODEL_IMX290LLR] = {
|
|
.colour_variant = IMX290_VARIANT_MONO,
|
|
.init_regs = imx290_global_init_settings_290,
|
|
.init_regs_num = ARRAY_SIZE(imx290_global_init_settings_290),
|
|
+ .max_analog_gain = 100,
|
|
.name = "imx290",
|
|
},
|
|
[IMX290_MODEL_IMX327LQR] = {
|
|
.colour_variant = IMX290_VARIANT_COLOUR,
|
|
.init_regs = imx290_global_init_settings_327,
|
|
.init_regs_num = ARRAY_SIZE(imx290_global_init_settings_327),
|
|
+ .max_analog_gain = 98,
|
|
.name = "imx327",
|
|
},
|
|
};
|