From 7ff3c4a9cf344c08cdac97ee82d986c5ee007605 Mon Sep 17 00:00:00 2001 From: Dave Stevenson Date: Thu, 21 Nov 2024 18:30:07 +0000 Subject: [PATCH] drm/connector: Initialise max_bpc to the minimum value supported Using increased bit depth for no reason increases power consumption, and differs from the behaviour prior to the conversion to use the HDMI helper functions. Initialise the state max_bpc and requested_max_bpc to the minimum value supported. This only affects Raspberry Pi, as the other users of the helpers (rockchip/inno_hdmi and sunx4i) only support a bit depth of 8. Signed-off-by: Dave Stevenson --- drivers/gpu/drm/display/drm_hdmi_state_helper.c | 2 +- drivers/gpu/drm/drm_connector.c | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) --- a/drivers/gpu/drm/display/drm_hdmi_state_helper.c +++ b/drivers/gpu/drm/display/drm_hdmi_state_helper.c @@ -24,7 +24,7 @@ void __drm_atomic_helper_connector_hdmi_ unsigned int max_bpc = connector->max_bpc; new_conn_state->max_bpc = max_bpc; - new_conn_state->max_requested_bpc = max_bpc; + new_conn_state->max_requested_bpc = 8; new_conn_state->hdmi.broadcast_rgb = DRM_HDMI_BROADCAST_RGB_AUTO; } EXPORT_SYMBOL(__drm_atomic_helper_connector_hdmi_reset); --- a/drivers/gpu/drm/drm_connector.c +++ b/drivers/gpu/drm/drm_connector.c @@ -2731,8 +2731,8 @@ int drm_connector_attach_max_bpc_propert } drm_object_attach_property(&connector->base, prop, max); - connector->state->max_requested_bpc = max; - connector->state->max_bpc = max; + connector->state->max_requested_bpc = min; + connector->state->max_bpc = min; return 0; }