Difuse/difos
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

mt76: Change CRLF to LF in patch 002

Browse source 
Change CRLF to LF in patch 002-wifi-mt76-replace-strlcpy-with-strscpy.patch

Fixes: 225622e0f9 ("mt76: replace strlcpy with strscpy")
Signed-off-by: Mieczyslaw Nalewaj <namiltd@yahoo.com>
Link: https://github.com/openwrt/openwrt/pull/19185
Signed-off-by: Hauke Mehrtens <hauke@hauke-m.de>
This commit is contained in:
Mieczyslaw Nalewaj 2025-06-19 22:26:45 +02:00 committed by Hauke Mehrtens
parent 97af506edf
commit dc95180540
1 changed files with 29 additions and 29 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

58
package/kernel/mt76/patches/002-wifi-mt76-replace-strlcpy-with-strscpy.patch
View file

@ -1,32 +1,32 @@
From d6b484b5cb2a7d509b36a220911509ddd8b777c4 Mon Sep 17 00:00:00 2001 From d6b484b5cb2a7d509b36a220911509ddd8b777c4 Mon Sep 17 00:00:00 2001
From: Azeem Shaikh <azeemshaikh38@gmail.com> From: Azeem Shaikh <azeemshaikh38@gmail.com>
Date: Mon, 3 Jul 2023 18:12:56 +0000 Date: Mon, 3 Jul 2023 18:12:56 +0000
Subject: wifi: mt76: Replace strlcpy() with strscpy() Subject: wifi: mt76: Replace strlcpy() with strscpy()
strlcpy() reads the entire source buffer first. strlcpy() reads the entire source buffer first.
This read may exceed the destination size limit. This read may exceed the destination size limit.
This is both inefficient and can lead to linear read This is both inefficient and can lead to linear read
overflows if a source string is not NUL-terminated [1]. overflows if a source string is not NUL-terminated [1].
In an effort to remove strlcpy() completely [2], replace In an effort to remove strlcpy() completely [2], replace
strlcpy() here with strscpy(). strlcpy() here with strscpy().
Direct replacement is safe here since DEV_ASSIGN is only used by Direct replacement is safe here since DEV_ASSIGN is only used by
TRACE macros and the return values are ignored. TRACE macros and the return values are ignored.
[1] https://www.kernel.org/doc/html/latest/process/deprecated.html#strlcpy [1] https://www.kernel.org/doc/html/latest/process/deprecated.html#strlcpy
[2] https://github.com/KSPP/linux/issues/89 [2] https://github.com/KSPP/linux/issues/89
Signed-off-by: Azeem Shaikh <azeemshaikh38@gmail.com> Signed-off-by: Azeem Shaikh <azeemshaikh38@gmail.com>
Reviewed-by: Kees Cook <keescook@chromium.org> Reviewed-by: Kees Cook <keescook@chromium.org>
Signed-off-by: Kalle Valo <kvalo@kernel.org> Signed-off-by: Kalle Valo <kvalo@kernel.org>
Link: https://lore.kernel.org/r/20230703181256.3712079-1-azeemshaikh38@gmail.com Link: https://lore.kernel.org/r/20230703181256.3712079-1-azeemshaikh38@gmail.com
--- ---
mt7615/mt7615_trace.h | 2 +- mt7615/mt7615_trace.h | 2 +-
mt76x02_trace.h | 2 +- mt76x02_trace.h | 2 +-
trace.h | 2 +- trace.h | 2 +-
usb_trace.h | 2 +- usb_trace.h | 2 +-
4 files changed, 4 insertions(+), 4 deletions(-) 4 files changed, 4 insertions(+), 4 deletions(-)
--- a/mt7615/mt7615_trace.h --- a/mt7615/mt7615_trace.h
+++ b/mt7615/mt7615_trace.h +++ b/mt7615/mt7615_trace.h
@@ -14,7 +14,7 @@ @@ -14,7 +14,7 @@