ipq806x: replace tsens patch with upstream version
Replace tsens patch with upstream version. Signed-off-by: Christian Marangi <ansuelsmth@gmail.com>
This commit is contained in:
parent
cf43e523c2
commit
dac2f07c23
4 changed files with 94 additions and 64 deletions
|
@ -1,18 +1,20 @@
|
||||||
From 8f32d48a309246a80bdca505968085a484d54408 Mon Sep 17 00:00:00 2001
|
From de48d8766afcd97d147699aaff78a338081c9973 Mon Sep 17 00:00:00 2001
|
||||||
From: Ansuel Smith <ansuelsmth@gmail.com>
|
From: Christian Marangi <ansuelsmth@gmail.com>
|
||||||
Date: Mon, 19 Apr 2021 03:01:53 +0200
|
Date: Sat, 22 Oct 2022 14:56:55 +0200
|
||||||
Subject: [thermal-next PATCH v2 1/2] thermal: qcom: tsens: init debugfs only with
|
Subject: [PATCH 1/3] thermal/drivers/qcom/tsens: Init debugfs only with
|
||||||
successful probe
|
successful probe
|
||||||
|
|
||||||
calibrate and tsens_register can fail or PROBE_DEFER. This will cause a
|
Calibrate and tsens_register can fail or PROBE_DEFER. This will cause a
|
||||||
double or a wrong init of the debugfs information. Init debugfs only
|
double or a wrong init of the debugfs information. Init debugfs only
|
||||||
with successful probe fixing warning about directory already present.
|
with successful probe fixing warning about directory already present.
|
||||||
|
|
||||||
Signed-off-by: Ansuel Smith <ansuelsmth@gmail.com>
|
Signed-off-by: Christian Marangi <ansuelsmth@gmail.com>
|
||||||
Acked-by: Thara Gopinath <thara.gopinath@linaro.org>
|
Acked-by: Thara Gopinath <thara.gopinath@linaro.org>
|
||||||
|
Link: https://lore.kernel.org/r/20221022125657.22530-2-ansuelsmth@gmail.com
|
||||||
|
Signed-off-by: Daniel Lezcano <daniel.lezcano@kernel.org>
|
||||||
---
|
---
|
||||||
drivers/thermal/qcom/tsens.c | 9 ++++++---
|
drivers/thermal/qcom/tsens.c | 8 +++++---
|
||||||
1 file changed, 6 insertions(+), 3 deletions(-)
|
1 file changed, 5 insertions(+), 3 deletions(-)
|
||||||
|
|
||||||
--- a/drivers/thermal/qcom/tsens.c
|
--- a/drivers/thermal/qcom/tsens.c
|
||||||
+++ b/drivers/thermal/qcom/tsens.c
|
+++ b/drivers/thermal/qcom/tsens.c
|
||||||
|
@ -25,13 +27,12 @@ Acked-by: Thara Gopinath <thara.gopinath@linaro.org>
|
||||||
err_put_device:
|
err_put_device:
|
||||||
put_device(&op->dev);
|
put_device(&op->dev);
|
||||||
return ret;
|
return ret;
|
||||||
@@ -1156,7 +1154,12 @@ static int tsens_probe(struct platform_d
|
@@ -1156,7 +1154,11 @@ static int tsens_probe(struct platform_d
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
- return tsens_register(priv);
|
- return tsens_register(priv);
|
||||||
+ ret = tsens_register(priv);
|
+ ret = tsens_register(priv);
|
||||||
+
|
|
||||||
+ if (!ret)
|
+ if (!ret)
|
||||||
+ tsens_debug_init(pdev);
|
+ tsens_debug_init(pdev);
|
||||||
+
|
+
|
|
@ -0,0 +1,29 @@
|
||||||
|
From c7e077e921fa94e0c06c8d14af6c0504c8a5f4bd Mon Sep 17 00:00:00 2001
|
||||||
|
From: Christian Marangi <ansuelsmth@gmail.com>
|
||||||
|
Date: Sat, 22 Oct 2022 14:56:56 +0200
|
||||||
|
Subject: [PATCH 2/3] thermal/drivers/qcom/tsens: Fix wrong version id
|
||||||
|
dbg_version_show
|
||||||
|
|
||||||
|
For VER_0 the version was incorrectly reported as 0.1.0.
|
||||||
|
|
||||||
|
Fix that and correctly report the major version for this old tsens
|
||||||
|
revision.
|
||||||
|
|
||||||
|
Signed-off-by: Christian Marangi <ansuelsmth@gmail.com>
|
||||||
|
Link: https://lore.kernel.org/r/20221022125657.22530-3-ansuelsmth@gmail.com
|
||||||
|
Signed-off-by: Daniel Lezcano <daniel.lezcano@kernel.org>
|
||||||
|
---
|
||||||
|
drivers/thermal/qcom/tsens.c | 2 +-
|
||||||
|
1 file changed, 1 insertion(+), 1 deletion(-)
|
||||||
|
|
||||||
|
--- a/drivers/thermal/qcom/tsens.c
|
||||||
|
+++ b/drivers/thermal/qcom/tsens.c
|
||||||
|
@@ -692,7 +692,7 @@ static int dbg_version_show(struct seq_f
|
||||||
|
return ret;
|
||||||
|
seq_printf(s, "%d.%d.%d\n", maj_ver, min_ver, step_ver);
|
||||||
|
} else {
|
||||||
|
- seq_puts(s, "0.1.0\n");
|
||||||
|
+ seq_printf(s, "0.%d.0\n", priv->feat->ver_major);
|
||||||
|
}
|
||||||
|
|
||||||
|
return 0;
|
|
@ -0,0 +1,54 @@
|
||||||
|
From 89992d95ed1046338c7866ef7bbe6de543a2af91 Mon Sep 17 00:00:00 2001
|
||||||
|
From: Christian Marangi <ansuelsmth@gmail.com>
|
||||||
|
Date: Sat, 22 Oct 2022 14:56:57 +0200
|
||||||
|
Subject: [PATCH 3/3] thermal/drivers/qcom/tsens: Rework debugfs file structure
|
||||||
|
|
||||||
|
The current tsens debugfs structure is composed by:
|
||||||
|
- a tsens dir in debugfs with a version file
|
||||||
|
- a directory for each tsens istance with sensors file to dump all the
|
||||||
|
sensors value.
|
||||||
|
|
||||||
|
This works on the assumption that we have the same version for each
|
||||||
|
istance but this assumption seems fragile and with more than one tsens
|
||||||
|
istance results in the version file not tracking each of them.
|
||||||
|
|
||||||
|
A better approach is to just create a subdirectory for each tsens
|
||||||
|
istance and put there version and sensors debugfs file.
|
||||||
|
|
||||||
|
Using this new implementation results in less code since debugfs entry
|
||||||
|
are created only on successful tsens probe.
|
||||||
|
|
||||||
|
Signed-off-by: Christian Marangi <ansuelsmth@gmail.com>
|
||||||
|
Link: https://lore.kernel.org/r/20221022125657.22530-4-ansuelsmth@gmail.com
|
||||||
|
Signed-off-by: Daniel Lezcano <daniel.lezcano@kernel.org>
|
||||||
|
---
|
||||||
|
drivers/thermal/qcom/tsens.c | 13 +++----------
|
||||||
|
1 file changed, 3 insertions(+), 10 deletions(-)
|
||||||
|
|
||||||
|
--- a/drivers/thermal/qcom/tsens.c
|
||||||
|
+++ b/drivers/thermal/qcom/tsens.c
|
||||||
|
@@ -704,21 +704,14 @@ DEFINE_SHOW_ATTRIBUTE(dbg_sensors);
|
||||||
|
static void tsens_debug_init(struct platform_device *pdev)
|
||||||
|
{
|
||||||
|
struct tsens_priv *priv = platform_get_drvdata(pdev);
|
||||||
|
- struct dentry *root, *file;
|
||||||
|
|
||||||
|
- root = debugfs_lookup("tsens", NULL);
|
||||||
|
- if (!root)
|
||||||
|
+ priv->debug_root = debugfs_lookup("tsens", NULL);
|
||||||
|
+ if (!priv->debug_root)
|
||||||
|
priv->debug_root = debugfs_create_dir("tsens", NULL);
|
||||||
|
- else
|
||||||
|
- priv->debug_root = root;
|
||||||
|
-
|
||||||
|
- file = debugfs_lookup("version", priv->debug_root);
|
||||||
|
- if (!file)
|
||||||
|
- debugfs_create_file("version", 0444, priv->debug_root,
|
||||||
|
- pdev, &dbg_version_fops);
|
||||||
|
|
||||||
|
/* A directory for each instance of the TSENS IP */
|
||||||
|
priv->debug = debugfs_create_dir(dev_name(&pdev->dev), priv->debug_root);
|
||||||
|
+ debugfs_create_file("version", 0444, priv->debug, pdev, &dbg_version_fops);
|
||||||
|
debugfs_create_file("sensors", 0444, priv->debug, pdev, &dbg_sensors_fops);
|
||||||
|
}
|
||||||
|
#else
|
|
@ -1,54 +0,0 @@
|
||||||
From 4204f22060f7a5d42c6ccb4d4c25a6a875571099 Mon Sep 17 00:00:00 2001
|
|
||||||
From: Ansuel Smith <ansuelsmth@gmail.com>
|
|
||||||
Date: Mon, 19 Apr 2021 03:08:37 +0200
|
|
||||||
Subject: [thermal-next PATCH v2 2/2] thermal: qcom: tsens: simplify debugfs init
|
|
||||||
function
|
|
||||||
|
|
||||||
Simplify debugfs init function.
|
|
||||||
- Add check for existing dev directory.
|
|
||||||
- Fix wrong version in dbg_version_show (with version 0.0.0, 0.1.0 was
|
|
||||||
incorrectly reported)
|
|
||||||
|
|
||||||
Signed-off-by: Ansuel Smith <ansuelsmth@gmail.com>
|
|
||||||
Reviewed-by: Thara Gopinath <thara.gopinath@linaro.org>
|
|
||||||
---
|
|
||||||
drivers/thermal/qcom/tsens.c | 16 +++++++---------
|
|
||||||
1 file changed, 7 insertions(+), 9 deletions(-)
|
|
||||||
|
|
||||||
--- a/drivers/thermal/qcom/tsens.c
|
|
||||||
+++ b/drivers/thermal/qcom/tsens.c
|
|
||||||
@@ -692,7 +692,7 @@ static int dbg_version_show(struct seq_f
|
|
||||||
return ret;
|
|
||||||
seq_printf(s, "%d.%d.%d\n", maj_ver, min_ver, step_ver);
|
|
||||||
} else {
|
|
||||||
- seq_puts(s, "0.1.0\n");
|
|
||||||
+ seq_printf(s, "0.%d.0\n", priv->feat->ver_major);
|
|
||||||
}
|
|
||||||
|
|
||||||
return 0;
|
|
||||||
@@ -704,21 +704,17 @@ DEFINE_SHOW_ATTRIBUTE(dbg_sensors);
|
|
||||||
static void tsens_debug_init(struct platform_device *pdev)
|
|
||||||
{
|
|
||||||
struct tsens_priv *priv = platform_get_drvdata(pdev);
|
|
||||||
- struct dentry *root, *file;
|
|
||||||
|
|
||||||
- root = debugfs_lookup("tsens", NULL);
|
|
||||||
- if (!root)
|
|
||||||
+ priv->debug_root = debugfs_lookup("tsens", NULL);
|
|
||||||
+ if (!priv->debug_root)
|
|
||||||
priv->debug_root = debugfs_create_dir("tsens", NULL);
|
|
||||||
- else
|
|
||||||
- priv->debug_root = root;
|
|
||||||
|
|
||||||
- file = debugfs_lookup("version", priv->debug_root);
|
|
||||||
- if (!file)
|
|
||||||
+ if (!debugfs_lookup("version", priv->debug_root))
|
|
||||||
debugfs_create_file("version", 0444, priv->debug_root,
|
|
||||||
pdev, &dbg_version_fops);
|
|
||||||
|
|
||||||
/* A directory for each instance of the TSENS IP */
|
|
||||||
- priv->debug = debugfs_create_dir(dev_name(&pdev->dev), priv->debug_root);
|
|
||||||
+ priv->debug = debugfs_lookup(dev_name(&pdev->dev), priv->debug_root);
|
|
||||||
debugfs_create_file("sensors", 0444, priv->debug, pdev, &dbg_sensors_fops);
|
|
||||||
}
|
|
||||||
#else
|
|
Loading…
Reference in a new issue