Difuse/difos
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

firmware-utils: mkfwimage: add -Wall, fix obvious bugs causing compile warnings

Browse source 
Signed-off-by: Matthias Schiffer <mschiffer@universe-factory.net>

SVN-Revision: 48827
This commit is contained in:
Felix Fietkau 2016-02-29 20:11:26 +00:00
parent 5168d43b16
commit bd93998df6
2 changed files with 6 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
tools/firmware-utils/Makefile
View file

@ -32,7 +32,7 @@ define Host/Compile
$(call cc,mkzynfw) $(call cc,mkzynfw)
$(call cc,lzma2eva,-lz) $(call cc,lzma2eva,-lz)
$(call cc,mkcasfw) $(call cc,mkcasfw)
$(call cc,mkfwimage,-lz) $(call cc,mkfwimage,-lz -Wall)
$(call cc,mkfwimage2,-lz) $(call cc,mkfwimage2,-lz)
$(call cc,imagetag imagetag_cmdline cyg_crc32) $(call cc,imagetag imagetag_cmdline cyg_crc32)
$(call cc,add_header) $(call cc,add_header)

12
tools/firmware-utils/src/mkfwimage.c
View file

@ -104,8 +104,6 @@ typedef struct part_data {
#define OPTIONS "B:hv:m:o:r:k:" #define OPTIONS "B:hv:m:o:r:k:"
static int debug = 0;
typedef struct image_info { typedef struct image_info {
char magic[16]; char magic[16];
char version[256]; char version[256];
@ -236,9 +234,9 @@ static int create_image_layout(const char* kernelfile, const char* rootfsfile, c
fw_layout_t* p; fw_layout_t* p;
p = &fw_layout_data[0]; p = &fw_layout_data[0];
while ((strlen(p->name) != 0) && (strncmp(p->name, board_name, sizeof(board_name)) != 0)) while (*p->name && (strcmp(p->name, board_name) != 0))
p++; p++;
if (p->name == NULL) { if (!*p->name) {
printf("BUG! Unable to find default fw layout!\n"); printf("BUG! Unable to find default fw layout!\n");
exit(-1); exit(-1);
} }
@ -247,7 +245,7 @@ static int create_image_layout(const char* kernelfile, const char* rootfsfile, c
strcpy(kernel->partition_name, "kernel"); strcpy(kernel->partition_name, "kernel");
kernel->partition_index = 1; kernel->partition_index = 1;
kernel->partition_baseaddr = p->kern_start; kernel->partition_baseaddr = p->kern_start;
if ( (kernel->partition_length = filelength(kernelfile)) < 0) return (-1); if ( (kernel->partition_length = filelength(kernelfile)) == (u_int32_t)-1) return (-1);
kernel->partition_memaddr = p->kern_entry; kernel->partition_memaddr = p->kern_entry;
kernel->partition_entryaddr = p->kern_entry; kernel->partition_entryaddr = p->kern_entry;
strncpy(kernel->filename, kernelfile, sizeof(kernel->filename)); strncpy(kernel->filename, kernelfile, sizeof(kernel->filename));
@ -263,8 +261,8 @@ static int create_image_layout(const char* kernelfile, const char* rootfsfile, c
rootfs->partition_entryaddr = 0x00000000; rootfs->partition_entryaddr = 0x00000000;
strncpy(rootfs->filename, rootfsfile, sizeof(rootfs->filename)); strncpy(rootfs->filename, rootfsfile, sizeof(rootfs->filename));
printf("kernel: %d 0x%08x\n", kernel->partition_length, kernel->partition_baseaddr); printf("kernel: %d 0x%08x\n", kernel->partition_length, kernel->partition_baseaddr);
printf("root: %d 0x%08x\n", rootfs->partition_length, rootfs->partition_baseaddr); printf("root: %d 0x%08x\n", rootfs->partition_length, rootfs->partition_baseaddr);
im->part_count = 2; im->part_count = 2;
return 0; return 0;