Difuse/difos
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

ramips: i2s: use devm for debugfs seqfile

Browse source 
Avoids some pointless boilerplate.

Signed-off-by: Rosen Penev <rosenp@gmail.com>
Link: https://github.com/openwrt/openwrt/pull/18675
Signed-off-by: Robert Marko <robimarko@gmail.com>
This commit is contained in:
Rosen Penev 2025-04-30 18:12:48 -07:00 committed by Robert Marko
parent 724248799e
commit 8ffd3dfb10
1 changed files with 3 additions and 21 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

24
target/linux/ramips/patches-6.6/835-asoc-add-mt7620-support.patch
View file

@ -59,7 +59,7 @@ Signed-off-by: John Crispin <blogic@openwrt.org>
+obj-$(CONFIG_SND_RALINK_SOC_I2S) += snd-soc-ralink-i2s.o +obj-$(CONFIG_SND_RALINK_SOC_I2S) += snd-soc-ralink-i2s.o
--- /dev/null --- /dev/null
+++ b/sound/soc/ralink/ralink-i2s.c +++ b/sound/soc/ralink/ralink-i2s.c
@@ -0,0 +1,939 @@ @@ -0,0 +1,921 @@
+/* +/*
+ * Copyright (C) 2010, Lars-Peter Clausen <lars@metafoo.de> + * Copyright (C) 2010, Lars-Peter Clausen <lars@metafoo.de>
+ * Copyright (C) 2016 Michael Lee <igvtee@gmail.com> + * Copyright (C) 2016 Michael Lee <igvtee@gmail.com>
@ -200,7 +200,6 @@ Signed-off-by: John Crispin <blogic@openwrt.org>
+ struct snd_dmaengine_dai_dma_data capture_dma_data; + struct snd_dmaengine_dai_dma_data capture_dma_data;
+ +
+ struct dentry *dbg_dir; + struct dentry *dbg_dir;
+ struct dentry *dbg_stats;
+ struct ralink_i2s_stats txstats; + struct ralink_i2s_stats txstats;
+ struct ralink_i2s_stats rxstats; + struct ralink_i2s_stats rxstats;
+}; +};
@ -696,37 +695,20 @@ Signed-off-by: John Crispin <blogic@openwrt.org>
+ return 0; + return 0;
+} +}
+ +
+static int ralink_i2s_stats_open(struct inode *inode, struct file *file)
+{
+ return single_open(file, ralink_i2s_stats_show, inode->i_private);
+}
+
+static const struct file_operations ralink_i2s_stats_ops = {
+ .open = ralink_i2s_stats_open,
+ .read = seq_read,
+ .llseek = seq_lseek,
+ .release = single_release,
+};
+
+static inline int ralink_i2s_debugfs_create(struct ralink_i2s *i2s) +static inline int ralink_i2s_debugfs_create(struct ralink_i2s *i2s)
+{ +{
+ i2s->dbg_dir = debugfs_create_dir(dev_name(i2s->dev), NULL); + i2s->dbg_dir = debugfs_create_dir(dev_name(i2s->dev), NULL);
+ if (!i2s->dbg_dir) + if (!i2s->dbg_dir)
+ return -ENOMEM; + return -ENOMEM;
+ +
+ i2s->dbg_stats = debugfs_create_file("stats", S_IRUGO, + debugfs_create_devm_seqfile(i2s->dev, "stats", i2s->dbg_dir,
+ i2s->dbg_dir, i2s, &ralink_i2s_stats_ops); + &ralink_i2s_stats_show);
+ if (!i2s->dbg_stats) {
+ debugfs_remove(i2s->dbg_dir);
+ return -ENOMEM;
+ }
+ +
+ return 0; + return 0;
+} +}
+ +
+static inline void ralink_i2s_debugfs_remove(struct ralink_i2s *i2s) +static inline void ralink_i2s_debugfs_remove(struct ralink_i2s *i2s)
+{ +{
+ debugfs_remove(i2s->dbg_stats);
+ debugfs_remove(i2s->dbg_dir); + debugfs_remove(i2s->dbg_dir);
+} +}
+#else +#else