Difuse/difos
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

base-files: fix wrong ucidef_set_network_device_mac network-device entry

Browse source 
The ucidef_set_network_device_* functions in uci-defaults.sh disagree
on whether to use "network-device" or "network_device" in board.json.
With the additional caveat that jshn will translate hyphens (-) into
underscores (_). This casues problems in netifd which expected
"network_device" causing boards which depend on assigning MACs in
board.json via uci-defaults.sh (or jshn in general) to fail.

This commit addresses the issue by using network_device in
uci-defaults.sh.

The bug was uncovered in the forums here:
https://forum.openwrt.org/t/support-for-rtl838x-based-managed-switches/57875/2596

This was exposed by commit 4ebba8a05d09 ("realtek: add support for HPE
1920-8g-poe+") where the board_config_load call from 03_gpio introduced
the key normalization by jshn.

Fixes: 9290539ca9 ("base-files: allow setting device and bridge macs")
Tested-by: Stijn Segers <foss@volatilesystems.org>
Signed-off-by: Michael 'ASAP' Weinrich <michael@a5ap.net>
[ improve commit title, description and fix wrong Tested-by tag ]
Signed-off-by: Christian Marangi <ansuelsmth@gmail.com>
This commit is contained in:
Michael 'ASAP' Weinrich 2023-10-05 19:39:58 -07:00 committed by Christian Marangi
parent 67ce60c5f9
commit 12bc79d6d5
No known key found for this signature in database
GPG key ID: AC001D09ADBFEAD7
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
package/base-files/files/lib/functions/uci-defaults.sh
View file

@ -107,7 +107,7 @@ ucidef_set_bridge_mac() {
} }
ucidef_set_network_device_mac() { ucidef_set_network_device_mac() {
json_select_object "network-device" json_select_object "network_device"
json_select_object "${1}" json_select_object "${1}"
json_add_string macaddr "${2}" json_add_string macaddr "${2}"
json_select .. json_select ..