From 0cf2db1fa19480d15535c0c5ae84ee5d7689b60e Mon Sep 17 00:00:00 2001 From: Markus Stockhausen Date: Tue, 20 May 2025 03:55:52 -0400 Subject: [PATCH] realtek: make use of serdes helper for Netgear GS310TP v1 Use the new INTERNAL_PHY_SDS() helper to describe the SFP ports. With this change the driver now knows that ports 24/26 are driven by serdes 4/5. For the RTL838x devices this is currently only an additional information for the mdio bus. It is not evaluated further because everything is hardcoded. REMARK! The original commit c829bc1f2c3c47e2 ("realtek: Add support for Netgear S350 series switches GS308T and GS310TP") says that the SFP ports are untested. Looking at device internal pictures from https://techinfodepot.shoutwiki.com/wiki/Netgear_GS310TP there are no external phys for the SFP ports. So fix port description. Signed-off-by: Markus Stockhausen Link: https://github.com/openwrt/openwrt/pull/18851 Signed-off-by: Robert Marko --- target/linux/realtek/dts/rtl8380_netgear_gs310tp-v1.dts | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/target/linux/realtek/dts/rtl8380_netgear_gs310tp-v1.dts b/target/linux/realtek/dts/rtl8380_netgear_gs310tp-v1.dts index 7974e423594..50f7563ce99 100644 --- a/target/linux/realtek/dts/rtl8380_netgear_gs310tp-v1.dts +++ b/target/linux/realtek/dts/rtl8380_netgear_gs310tp-v1.dts @@ -50,13 +50,13 @@ }; &mdio { - INTERNAL_PHY(24) - INTERNAL_PHY(26) + INTERNAL_PHY_SDS(24, 4) + INTERNAL_PHY_SDS(26, 5) }; &switch0 { ports { - SWITCH_SFP_PORT(24, 9, rgmii-id) - SWITCH_SFP_PORT(26, 10, rgmii-id) + SWITCH_SFP_PORT(24, 9, 1000base-x) + SWITCH_SFP_PORT(26, 10, 1000base-x) }; };